Fix EditStaff dialog crash on startup#32744
Closed
CubikingChill wants to merge 1 commit intomusescore:masterfrom
Closed
Fix EditStaff dialog crash on startup#32744CubikingChill wants to merge 1 commit intomusescore:masterfrom
CubikingChill wants to merge 1 commit intomusescore:masterfrom
Conversation
1fba4f0 to
b7e0491
Compare
The crash occurred because initStaff() was called in the constructor before the context injection system was fully initialized. After the MUSE_MULTICONTEXT_WIP removal, globalContext() returns null during construction, causing a segfault when notation() is called. Fixed by moving initStaff() from the constructor to showEvent(), ensuring the context is ready before accessing it.
b7e0491 to
90f66d0
Compare
Contributor
|
replaced by #32757 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The crash occurred because initStaff() was called in the constructor before the context injection system was fully initialized. After the MUSE_MULTICONTEXT_WIP removal, globalContext() returns null during construction, causing a segfault when notation() is called.
Fixed by moving initStaff() from the constructor to showEvent(), ensuring the context is ready before accessing it.
Resolves: #32743